Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update My Program tab layout #1046

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Update My Program tab layout #1046

merged 8 commits into from
Sep 2, 2024

Conversation

manevala
Copy link
Contributor

@manevala manevala commented Aug 31, 2024

Update layout on My Program tab. Add link to admission ticket.

Screenshot 2024-08-31 at 11 43 45

@manevala manevala marked this pull request as ready for review August 31, 2024 11:23
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";

/**
* Specify
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onko tää TODO?

@Archinowsk
Copy link
Collaborator

Archinowsk commented Sep 1, 2024

Tää on vanha ongelma mutta huomasin, että kun avaa ohjelmanumeron tiedot, scroll position on edelleen sama. Eli kun scrollaat "oma ohjelmani" sivua alemmas ja avaat ohjelmanumeron tiedot, ohjelmanumeron sivu on scrollattu samaan kohtaan.

Ei tarvii välttämättä tässä tehdä, mutta voisi olla että scroll position nollataan, kun ohjelmanumeron tiedot avataan. Siirtymä on muuten vähän sekava, kun paluunuoli on piilossa ja aukeaa keskeltä ohjelmatietoja.

Sama homma ohjelmalistassa ja luultavasti muuallakin.

Tein tästä varmuudeksi myös tiketin Miroon.

Copy link
Collaborator

@Archinowsk Archinowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyvin toimii!

@manevala manevala force-pushed the feature/new-my-program-layout branch from 54d2c2b to 3c6fb03 Compare September 2, 2024 15:58
@manevala manevala merged commit 6e396e4 into main Sep 2, 2024
1 check passed
@manevala manevala deleted the feature/new-my-program-layout branch September 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants